Fix Codex image generation output handling#1
Open
vekexasia wants to merge 1 commit into
Open
Conversation
Author
|
A bit more context from the repro/debugging session:
One thing worth reviewing carefully: this reads the existing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
image_generationexecute as a normal Pi function tool instead of relying on native tool rewrite support.image_generation_call.result, and save the generated PNG under.pi/openai-codex-images/withlatest.pngmirror.view_imageand update docs/skill text to describe the new behavior.Why
In current Pi, native
image_generation_callstream items from Codex are not converted into agent-visible image/tool output. The previous rewrite-based implementation can therefore result in an empty assistant response while the model believes the image was generated.This patch keeps the fix inside this extension by handling the image generation response directly.
Verification
npm pack --dry-runtsx -e "import('./extensions/codex-image.ts').then(()=>console.log('import-ok'))"openai-codex/gpt-5.5verified:image_generationisError: false.pi/openai-codex-images/latest.pngwas created as a valid PNG