Open
Conversation
lucaslyl
approved these changes
May 8, 2026
Contributor
lucaslyl
left a comment
lucaslyl
left a comment
There was a problem hiding this comment.
Great! Could you please fix the lint and typecheck failures first before we merge it?
Author
|
I will, this isn’t ready to merge until the equivalent PR in the monorepo has been deployed to production. But where do the lint rules come from for this? I don’t even see a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same pattern as cardstack/boxel#4627; that PR has a script that applies this transformation when this repository is brought into the monorepo, which will no longer be necessary after this PR is merged.