feat(terminal): support custom SSH ports#1451
Conversation
# Conflicts: # PROGRESS.md # deploy/docker/agent-dev-container/Dockerfile # deploy/scripts/create-agent-dev-container.sh # deploy/scripts/test-create-agent-dev-container.sh
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0898b203b2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (defaults.length > 0 && hostRows.length > 0) { | ||
| await tx.insert(alertRules).values( | ||
| hostRows.flatMap((host) => cloneMetricDefaultsForHost(defaults, instanceId, host.id)), | ||
| ) |
There was a problem hiding this comment.
Building a single INSERT ... VALUES from hostRows.flatMap(...) can exceed PostgreSQL's bind-parameter limit in larger instances (rows = hosts × defaults, with multiple bound columns per row), causing replaceAllHostMetricAlertsWithGlobalDefaults to fail for high host counts and return a generic error instead of applying defaults. This is introduced here because the all-host path now attempts one monolithic insert; chunking inserts (or inserting per host/default batch) would prevent scale-dependent failures.
Useful? React with 👍 / 👎.
2 participants
Summary
Validation