Skip to content

fix(hosts): clean docker rows on delete#1453

Merged
simonjcarr merged 1 commit into
mainfrom
fix/host-delete-ssh-diagnostics
May 16, 2026
Merged

fix(hosts): clean docker rows on delete#1453
simonjcarr merged 1 commit into
mainfrom
fix/host-delete-ssh-diagnostics

Conversation

@simonjcarr
Copy link
Copy Markdown
Collaborator

Summary

  • delete Docker inventory and telemetry dependants before hard-deleting a host
  • preserve real SSH authentication failures while reporting non-auth SSH connection errors separately
  • add focused regression coverage for both paths

Root cause

Host deletion did not clear the newer Docker tables that reference hosts, so deleting hosts with Docker status or telemetry could fail on foreign key constraints. The terminal websocket also defaulted all SSH open failures to SSH authentication failed, which hid DNS/network/session errors behind a misleading password error.

Validation

  • node --test apps/web/lib/actions/agents-delete-hard.test.mjs
  • go test ./apps/ingest/internal/handlers ./apps/ingest/internal/db/queries
  • pnpm --filter web type-check

@simonjcarr simonjcarr merged commit 306848b into main May 16, 2026
20 checks passed
@simonjcarr simonjcarr deleted the fix/host-delete-ssh-diagnostics branch May 16, 2026 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant