-
Notifications
You must be signed in to change notification settings - Fork 101
Umbrella kickoff! #2499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Umbrella kickoff! #2499
Conversation
Signed-off-by: Jamie Pryde <[email protected]>
Signed-off-by: Jamie Pryde <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for the new Ceph release "umbrella" (version 21.*) across build, test, and CI/CD infrastructure.
- Introduces version 21.* → "umbrella" mapping in build utilities
- Adds "umbrella" to release lists and branch configurations across all CI/CD pipelines
- Configures build targets with noble, jammy, centos9, and windows distributions
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| scripts/sync-push | Adds "umbrella" to default releases for sync operations |
| scripts/sign-rpms | Adds "umbrella" to default releases for RPM signing |
| scripts/build_utils.sh | Maps version 21.* to "umbrella" release and updates default release from "tentacle" to "umbrella" |
| quay-pruner/build/delete-tags.py | Adds "umbrella" to protected release tags to prevent deletion |
| ceph-windows-pull-requests/config/definitions/ceph-windows-pull-requests.yml | Whitelists "umbrella" branch for Windows PR builds |
| ceph-volume-nightly/config/definitions/ceph-volume-nightly.yml | Adds "umbrella" branch to nightly ceph-volume test runs |
| ceph-trigger-build/build/Jenkinsfile | Configures build parameters for umbrella branches (centos9, arm64, crimson-debug) |
| ceph-pr-api/config/definitions/ceph-pr-api.yml | Whitelists "umbrella" branch for PR API processing |
| ceph-dev-new-trigger/config/definitions/ceph-dev-new-trigger.yml | Adds umbrella build triggers and excludes umbrella from fallback builds |
| ceph-dev-cron/config/definitions/ceph-dev-cron.yml | Adds umbrella branch polling and cron-based build configuration |
| ceph-dev-build/build/setup_osc | Configures OpenSUSE 15.3 as the distro for umbrella builds |
| ceph-dev-build/build/build_osc | Sets OpenSUSE Leap 15.3 OBS repository for umbrella |
| ceph-dashboard-cephadm-e2e-nightly/config/definitions/ceph-dashboard-cephadm-e2e-nightly.yml | Adds "umbrella" branch to dashboard end-to-end nightly tests |
| ceph-build/config/definitions/ceph-build.yml | Includes "umbrella" in regex pattern for distro-specific build conditions |
| ceph-api-nightly/config/definitions/ceph-api-nightly.yml | Adds "umbrella" branch to API nightly test runs |
| attic/ceph-dev-trigger/config/definitions/ceph-dev-trigger.yml | Adds umbrella branch and build configuration to archived trigger job |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| FLAVOR=crimson | ||
| # build umbrella on: | ||
| # default: jammy focal centos8 centos9 | ||
| # crimson: centos8 centos9 |
Copilot
AI
Dec 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment states "crimson: centos8 centos9" but the actual FLAVOR parameter is just "crimson" without the "centos8" qualifier. This is inconsistent with the actual build configuration in line 141 which only specifies centos9. The comment should be updated to match the actual configuration: "# crimson: centos9".
| # crimson: centos8 centos9 | |
| # crimson: centos9 |
aainscow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I want others to review before we merge.
Main Umbrella kickoff PR: ceph/ceph#66524