Skip to content

feat: Enable compilation on/for arm64 targets#6

Closed
the-wondersmith wants to merge 1 commit into
chainer:masterfrom
the-wondersmith:master
Closed

feat: Enable compilation on/for arm64 targets#6
the-wondersmith wants to merge 1 commit into
chainer:masterfrom
the-wondersmith:master

Conversation

@the-wondersmith
Copy link
Copy Markdown

PR puts the inclusion of xmmintrin.h behind an if defined check to enable compiling daz for/on arm64 targets

@kmaehashi
Copy link
Copy Markdown
Member

I don't think _mm_getcsr x86 intrinsics is supported on Arm64?

@hayguen
Copy link
Copy Markdown

hayguen commented Aug 12, 2023

I don't think _mm_getcsr x86 intrinsics is supported on Arm64?

you are right. fixed this at https://github.com/hayguen/daz
but finally, on systems without SSE like ARM, the functions do nothing

@the-wondersmith
Copy link
Copy Markdown
Author

@hayguen So... (just clarifying) the PR can be closed?

@hayguen
Copy link
Copy Markdown

hayguen commented Aug 14, 2023

@the-wondersmith : IMHO yes, in case my pull request #8 would get accepted, yours would get obsoleted. but i fear, there is no reaction from @chainer ?!

in addition, your PR doesn't compile/run on ARM, that is, why i added commit 0d08e77

@the-wondersmith
Copy link
Copy Markdown
Author

@hayguen 🫡 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants