Skip to content

feat: store cas backend information in attestation #2632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Piskoo wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: store cas backend information in attestation #2632

Piskoo wants to merge 2 commits into from
+462 −104

Conversation

@Piskoo
Copy link
Collaborator

@Piskoo Piskoo commented Dec 22, 2025

Adds information about cas backend used in attestation process to the attestation

Part of attestation statement

  "predicate": {
    "casBackend": {
      "casBackendId": "07ddd65b-ed78-43ab-8914-659aab11f5c3",
      "casBackendName": "casb",
      "fallback": false
    },

Closes #2631

@Piskoo
store cas backend info in atttestation
5d84403 
Signed-off-by: Sylwester Piskozub <[email protected]>
@Piskoo Piskoo changed the title feat: store cas backend information in atttestation feat: store cas backend information in attestation Dec 22, 2025
@Piskoo Piskoo requested review from jiparis and migmartri December 22, 2025 14:03
@Piskoo Piskoo marked this pull request as ready for review December 22, 2025 14:03
jiparis
jiparis reviewed Dec 22, 2025
View reviewed changes
@Piskoo
refactor
46ae5ba 
Signed-off-by: Sylwester Piskozub <[email protected]>
migmartri
migmartri reviewed Dec 23, 2025
View reviewed changes
pkg/attestation/crafter/api/attestation/v1/crafting_state.proto

message CASBackend {
// UUID of the CAS backend
string cas_backend_id = 1 [(buf.validate.field).string = {min_len: 1}];
Copy link
Member

@migmartri migmartri Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should use the uuid validation here instead

migmartri
migmartri approved these changes Dec 23, 2025
View reviewed changes
Copy link
Member

@migmartri migmartri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ptal at the my comments.

Thanks!

pkg/attestation/renderer/chainloop/chainloop.go
}

type CASBackend struct {
CASBackendID string `json:"casBackendId"`
Copy link
Member

@migmartri migmartri Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
CASBackendID string `json:"casBackendId"`
CASBackendID string `json:"casBackendID"`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jiparis jiparis jiparis left review comments

@migmartri migmartri migmartri approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: add cas backend tracking to attestations

3 participants

@Piskoo @migmartri @jiparis