Fix #12191: splice with single argument throws RangeError#12202
Open
cobyfrombrooklyn-bot wants to merge 1 commit intochartjs:masterfrom
Open
Fix #12191: splice with single argument throws RangeError#12202cobyfrombrooklyn-bot wants to merge 1 commit intochartjs:masterfrom
cobyfrombrooklyn-bot wants to merge 1 commit intochartjs:masterfrom
Conversation
When calling data.splice(0) with only one argument, _onDataSplice computed newCount as arguments.length - 2 = -1, which is an invalid array length. Fixed by using Math.max(0, ...) to clamp to zero. Fixes chartjs#12191
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling
data.splice(0)with only one argument (which should clear the array),_onDataSplicecomputednewCountasarguments.length - 2 = -1, causing aRangeError: Invalid array length.Fix
Changed
arguments.length - 2toMath.max(0, arguments.length - 2)incore.datasetController.jsto clampnewCountto zero when fewer than 2 arguments are passed.Test
Added test case
should handle splice with a single argument without throwing (issue #12191)incore.datasetController.tests.jsthat:data.splice(0)(single argument)meta.data.lengthanddata.lengthare both 0Test fails without the fix (RangeError), passes with it. Full test suite passes on macOS ARM (Apple Silicon, ChromeHeadless).