feat: Remove imap::Session::sync_seen_flags()#7758
Open
Conversation
iequidoo
force-pushed
the
iequidoo/rm-sync_seen_flags
branch
from
266cc9f to
397de34
Compare
iequidoo
force-pushed
the
iequidoo/rm-sync_seen_flags
branch
2 times, most recently
from
3955b41 to
91ea007
Compare
iequidoo
changed the title
iequidoo
force-pushed
the
iequidoo/rm-sync_seen_flags
branch
4 times, most recently
from
15feacb to
dcbfecc
Compare
This comment was marked as outdated.
This comment was marked as outdated.
iequidoo
force-pushed
the
iequidoo/rm-sync_seen_flags
branch
from
dcbfecc to
6dbd1ae
Compare
This comment was marked as resolved.
This comment was marked as resolved.
iequidoo
force-pushed
the
iequidoo/rm-sync_seen_flags
branch
2 times, most recently
from
d83f90d to
b25b500
Compare
Collaborator
Author
|
#8064 should be merged first, EDIT: Added it as a first commit so that the tests pass. |
…efore sending outgoing one We don't want to send an outgoing message from the 2nd device (`ac1_clone`) before receiving the incoming one and expect that the messages will be ordered correctly on the 1st device (`ac1`). Let's ensure the correct message order locally in the first place. I checked logs of a failed test run and it indeed happened that `ac1_clone` sent the message earlier, so it can't reference the incoming message and `tweak_sort_timestamp()` does nothing on `ac1`, so the messages can't be ordered correctly considering that smeared clocks on the devices are diferent.
This way they also can be processed by `markseen_msgs()` resulting in self-MDNs which improves multi-device synchronization. MDNs to contacts won't really be sent because silent group changes messages are self-removal messages which don't request MDNs.
iequidoo
force-pushed
the
iequidoo/rm-sync_seen_flags
branch
from
b25b500 to
d68cee9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #7742
Maybe we should merge this first and then #7928 will be easier to debug, maybe it will reproduce more stably or, vice versa, disappear at all.However, there's a problem (maybe): with this change, messages will start to arrive always unseen and then be marked as seen as soon as MDNs are received, this will probably cause notifications to appear and then disappear quickly if messages have been already seen on another device.We still store\Seenflags on IMAP.