test: Test that messages are only marked as delivered after being fully sent out#8077
Open
test: Test that messages are only marked as delivered after being fully sent out#8077
Conversation
link2xt
approved these changes
Apr 2, 2026
| alice | ||
| .sql | ||
| .query_row_optional( | ||
| r#" |
Collaborator
There was a problem hiding this comment.
No need for r# here, there are no quotes inside the query.
| .sql | ||
| .query_row_optional( | ||
| r#" | ||
| SELECT id, msg_id, mime, recipients |
Collaborator
There was a problem hiding this comment.
You select id and recipients, but then don't actually use them.
Query can be SELECT msg_id, mime FROM smtp ORDER BY id.
iequidoo
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test for #8062. I checked that the test fails without #8062.