refactor: move ensure_secret_key_exists into key.rs#8353
Merged
Conversation
link2xt
force-pushed
the
link2xt/kuoszqtkyklu
branch
from
5519f33 to
0358ace
Compare
link2xt
commented
Jun 20, 2026
| /// sent but in a few locations there are no such guarantees, | ||
| /// e.g. when exporting keys, and calling this function ensures a | ||
| /// private key will be present. | ||
| // TODO, remove this once deltachat::key::Key no longer exists. |
Collaborator
Author
There was a problem hiding this comment.
Also removed this TODO. Unclear what "this" is and the function itself cannot be removed easily, it is used for example to make sure the key exists before exporting a backup.
iequidoo
approved these changes
Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #8345 i'm removing EncryptHelper so this function and the tests are the only things that remain in
e2eemodule. If we move the remaining tests somewhere then we can removee2eemodule completely.