chore: add final to 258 leaf classes (non-extended, non-abstract, non-Impl)#561
Open
armando-rodriguez-cko wants to merge 1 commit intomasterfrom
Open
chore: add final to 258 leaf classes (non-extended, non-abstract, non-Impl)#561armando-rodriguez-cko wants to merge 1 commit intomasterfrom
armando-rodriguez-cko wants to merge 1 commit intomasterfrom
Conversation
…-Impl) Systematic technical debt cleanup: all concrete classes that are not extended by any other class in the codebase now declare final. Excludes *ClientImpl classes (repo-wide convention without final) and Abstract* classes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates multiple classes across the codebase to make them
final. By marking these classes asfinal, we prevent them from being subclassed, which can improve code safety, maintainability, and potentially performance. The changes are primarily focused on model, configuration, and utility classes.Key changes include:
General codebase hardening:
CheckoutArgumentExceptionandCheckoutAuthorizationExceptionfinal to prevent further subclassing and reinforce their intended usage. [1] [2]CustomEnvironment,CustomTransportConfiguration,DefaultTransportConfiguration,Resilience4jConfiguration, andEnvironmentSubdomainas final. [1] [2] [3] [4] [5]GsonSerializerandCustomAwsRedirectStrategy, to be final. [1] [2]Model and response classes:
ContentResponse,ItemsResponse,RequestMetrics, and several account-related classes (AccountsCorporateAccountHolder,AccountsIndividualAccountHolder,EntityFinancialDetails,EntityFinancialDocuments,EntityMemberResponse,EntityMembersResponse,InstrumentDetailsCardToken,InstrumentDetailsFasterPayments). [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]These changes collectively ensure that these classes cannot be extended, which helps enforce their intended design and usage throughout the codebase.