Add signed types#368
Open
AmmoniumX wants to merge 13 commits into
Open
Conversation
…uce code duplication
Add span overloads based on static extent
|
Author
|
@chfast the PR is ready for review. The failed tests are false negatives since Clang warns of using "delete with a message" as a C++26 extension but we are already guarding against that with the INTX_DELETE macro. Let me know if you want any changes :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #112
This PR aims to add signed variants for custom integers as a wrapper over the unsigned types, using two's complement