Skip to content

Conversation

@nickschot
Copy link

@nickschot nickschot commented Mar 9, 2022

This fixes an issue where the dropdown content could be invisible in tests due to the transitioning in class always being set. Could break visual regression testing etc. in cases where the style for this class makes the dropdown invisible

@nickschot
Copy link
Author

nickschot commented Mar 9, 2022

🤦 oh this was added here as in a fix for app behaviour: #628

Double checking... but the current behaviour is also not great as it can break tests/percy in the way I described

edit: I think this change is still correct for the described use case, keeps the fix intact and makes it render in tests properly again. Separately from this, the original problem that #628 seems to solve still appears to be broken for dropdowns that are rendered in place regardless of this MR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant