This fixes the removed MediaStream.stop() for chrome 47#34
Open
zzzk wants to merge 1 commit intocirocosta:masterfrom
Open
This fixes the removed MediaStream.stop() for chrome 47#34zzzk wants to merge 1 commit intocirocosta:masterfrom
zzzk wants to merge 1 commit intocirocosta:masterfrom
Conversation
…nymore in Chrome 47 (https://developers.google.com/web/updates/2015/07/mediastream-deprecations?hl=en) fixed stopping each track individually. See also https://developer.mozilla.org/en/docs/Web/API/MediaStream for browser compatibility. Library gulp-livereload was missing for building the sources.
zzzk
force-pushed
the
master
branch
2 times, most recently
from
7b1468a to
39af7cc
Compare
Author
|
Hi Ciro, |
|
@cirocosta Is there something that I can do to get this merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mediastream.stop() is deprecated since Chrome 45 and does not work anymore with Chrome 47. This pull request fixes the issue in calling stop() for each track of the stream. Note you can reproduce the error with the capture example implementation of https://cirocosta.github.io/qcode-decoder/