Skip to content

修复vendor环境以修复本地搜索与音频采集#57

Closed
HELPMEEADICE wants to merge 1 commit intoclaude-code-best:mainfrom
HELPMEEADICE:main
Closed

修复vendor环境以修复本地搜索与音频采集#57
HELPMEEADICE wants to merge 1 commit intoclaude-code-best:mainfrom
HELPMEEADICE:main

Conversation

@HELPMEEADICE
Copy link
Copy Markdown

@HELPMEEADICE HELPMEEADICE commented Apr 2, 2026

rt,否则cc只能以极其低效的bash模式进行搜索

Summary by CodeRabbit

  • Chores
    • Added licensing documentation for a bundled vendor library.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 95a36297-186a-4a34-b108-840c3df731ad

📥 Commits

Reviewing files that changed from the base of the PR and between 1f0a2e4 and 6f345fb.

⛔ Files ignored due to path filters (2)
  • src/utils/vendor/ripgrep/arm64-win32/rg.exe is excluded by !**/*.exe
  • src/utils/vendor/ripgrep/x64-win32/rg.exe is excluded by !**/*.exe
📒 Files selected for processing (11)
  • src/utils/vendor/audio-capture/arm64-darwin/audio-capture.node
  • src/utils/vendor/audio-capture/arm64-linux/audio-capture.node
  • src/utils/vendor/audio-capture/arm64-win32/audio-capture.node
  • src/utils/vendor/audio-capture/x64-darwin/audio-capture.node
  • src/utils/vendor/audio-capture/x64-linux/audio-capture.node
  • src/utils/vendor/audio-capture/x64-win32/audio-capture.node
  • src/utils/vendor/ripgrep/COPYING
  • src/utils/vendor/ripgrep/arm64-darwin/rg
  • src/utils/vendor/ripgrep/arm64-linux/rg
  • src/utils/vendor/ripgrep/x64-darwin/rg
  • src/utils/vendor/ripgrep/x64-linux/rg

📝 Walkthrough

Walkthrough

A licensing file (COPYING) has been added to the ripgrep vendor directory, documenting dual-license status under the Unlicense and MIT licenses.

Changes

Cohort / File(s) Summary
Ripgrep Licensing
src/utils/vendor/ripgrep/COPYING
Added COPYING file with dual-license declaration (Unlicense and MIT).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A license file hops into place,
Dual permissions at a gentle pace,
Unlicense and MIT share the grace,
Legal clarity wins the race! 📜✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title is in Chinese and refers to fixing vendor environment for local search and audio collection, but the actual change is only adding a COPYING licensing file for ripgrep. Update the title to accurately reflect the change, such as 'Add COPYING license file for ripgrep vendor' or similar, as the current title does not describe the actual modification.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@claude-code-best
Copy link
Copy Markdown
Owner

懂得, 但是我们现在没法保证这些个 二进制文件的稳定性啊, 每次变更需要变, 当然 vscode 的 rp 可以用, 但是音频的还是不知道来源 @HELPMEEADICE

@keydexofficial
Copy link
Copy Markdown

vendor的内容从 claude code官方包扣出来就行。官方npm的肯定是稳定的啊

@HELPMEEADICE
Copy link
Copy Markdown
Author

这个vendor是从官方npm扣的 @claude-code-best

@claude-code-best
Copy link
Copy Markdown
Owner

暂时现在采用了 vscode 的rg,现在这版本暂时是这样, 音频采集将会单独成立一个 issues 跟进

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants