fix: disabling start for middle mouse button#852
Open
cgood92 wants to merge 1 commit intoclauderic:masterfrom
Open
fix: disabling start for middle mouse button#852cgood92 wants to merge 1 commit intoclauderic:masterfrom
cgood92 wants to merge 1 commit intoclauderic:masterfrom
Conversation
There are 3 possible values for `event.button`: - 0: left mouse button - 1: middle mouse button - 2: right mouse button We should not start dragging if either middle or right mouse buttons are clicked
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5b31ad4:
|
cgood92
commented
Aug 22, 2022
| const {distance, shouldCancelStart} = this.props; | ||
|
|
||
| if (event.button === 2 || shouldCancelStart(event)) { | ||
| if (event.button !== LEFT_MOUSE_BUTTON || shouldCancelStart(event)) { |
Author
There was a problem hiding this comment.
Please note: event.button is well supported: https://developer.mozilla.org/en-US/docs/Web/API/MouseEvent/button, and could be a number 0-4. But, we should only activate for left mouse button.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: disabling start for middle mouse button
There are 5 possible values for
event.button:(Source: https://developer.mozilla.org/en-US/docs/Web/API/MouseEvent/button)
We should not start dragging if either middle or right mouse buttons are clicked
I did not see any unit tests, please let me know if I missed that, as I would be happy to add a unit test.