Draft
Conversation
USA-RedDragon
force-pushed
the
rootless
branch
4 times, most recently
from
f422269 to
efb140b
Compare
USA-RedDragon
force-pushed
the
rootless
branch
2 times, most recently
from
6c5d65c to
2f8aa68
Compare
USA-RedDragon
force-pushed
the
rootless
branch
from
2f8aa68 to
1452f9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
-rootlessversions of the images in order to facilitate migration to rootless containers.The containers run as
www-data:www-dataand on port 8080.The existing images are adjusted in some minor ways:
/var/lib/nginx/tmpand/var/log/nginxare created by defaultWORKDIR /appis not set inbaseas none of the build instructions seem to rely on that (also, so we can create it after we swap users withUSERinbase-rootless)NGINX_PORT, but this should result in the same output as prior to this PR after aclevyr-builds6-svscan-rootlessutility is added that uses/tmpto provide a place for the.s6-svscanfile to live. This goes unused in the base image that's not rootless, but does exist in the filesystem.I have a draft PR 1291 in another repo that I won't link due to the name of it being a privacy concern that shows how this might look on the application side