Create db.lock file only for persistent databases
#3912
Merged
+563
−396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gefjon
approved these changes
Dec 29, 2025
Contributor
gefjon
left a comment
gefjon
left a comment
There was a problem hiding this comment.
Comment-ey nits. This looks reasonable to me.
kim
force-pushed
the
kim/move-lockfile
branch
3 times, most recently
from
407d197 to
1f623f0
Compare
This is the first step to make in-memory only databases not touch the disk at all. Pending is an in-memory only sink for module logs. Responsibility for the lock file is transferred to `Durability`, which means that only persistent databases opened for writing acquire the lock. As a consequence, the `Durability` trait gains a `close` method that prevents further writes and drains the internal buffers, even when multiple `Arc`-pointers to the `Durability` exist.
Shubham8287
approved these changes
Jan 6, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 7, 2026
This is the first step to make in-memory only databases not touch the disk at all. Pending is an in-memory only sink for module logs. Responsibility for the lock file is transferred to `Durability`, which means that only persistent databases opened for writing acquire the lock. As a consequence, the `Durability` trait gains a `close` method that prevents further writes and drains the internal buffers, even when multiple `Arc`-pointers to the `Durability` exist. # Expected complexity level and risk 2 # Testing Covered by existing tests.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step to make in-memory only databases not touch the disk at all. Pending is an in-memory only sink for module logs.
Responsibility for the lock file is transferred to
Durability, which means that only persistent databases opened for writing acquire the lock.As a consequence, the
Durabilitytrait gains aclosemethod that prevents further writes and drains the internal buffers, even when multipleArc-pointers to theDurabilityexist.Expected complexity level and risk
2
Testing
Covered by existing tests.