fix view deadlock #3938
Merged
fix view deadlock #3938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gefjon
reviewed
Dec 30, 2025
Contributor
gefjon
left a comment
gefjon
left a comment
There was a problem hiding this comment.
Very preliminary, not a full review, but I have some concerns.
gefjon
approved these changes
Dec 30, 2025
Contributor
gefjon
left a comment
gefjon
left a comment
There was a problem hiding this comment.
I feel reasonably OK with this PR. I'd be happier if we had more rigorous testing, and if we had more of the team here, especially @joshua-spacetime . But given the time and the importance of this bugfix, I think it's good to merge.
jdetter
pushed a commit
that referenced
this pull request
Dec 30, 2025
# Description of Changes Fixes a deadlock in the subscription code and HTTP SQL handler that was caused by calling view methods on the module while holding the transaction lock. I tried a couple of approaches to make the closures `Send` for all code paths that need to hold the transaction while working with views, but that didn’t work out well. The V8 module communicates with the host through channels, which would require dynamic dispatch. In the current approach, all existing methods that were calling views from the host are now invoked from inside the module itself. In future, It will be better to move these methods to common place rather than being scattrered.
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 6, 2026
# Description of Changes Exntention of #3938 to polish some of the code, which was not done in original PR due to hurry. - Adds some missing commentary. - code cleaning mostly limited to changed functions signature. # API and ABI breaking changes NA # Expected complexity level and risk 0 # Testing Exisiting tests should be enough. --------- Signed-off-by: Shubham Mishra <[email protected]> Co-authored-by: joshua-spacetime <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fixes a deadlock in the subscription code and HTTP SQL handler that was caused by calling view methods on the module while holding the transaction lock.
I tried a couple of approaches to make the closures
Sendfor all code paths that need to hold the transaction while working with views, but that didn’t work out well. The V8 module communicates with the host through channels, which would require dynamic dispatch.In the current approach, all existing methods that were calling views from the host are now invoked from inside the module itself. In future, It will be better to move these methods to common place rather than being scattrered.