Skip to content

Update release-npm workflow for dryruns #5634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rekhoff wants to merge 2 commits into from
Closed

Update release-npm workflow for dryruns #5634

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eefe616
Update release-npm workflow for dryruns
rekhoff Jul 31, 2026
1ba7355
Update lint
rekhoff Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 26 additions & 6 deletions tools/release/src/targets/npm.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ impl NpmRelease {

let sdk_dir = Path::new("sdks/typescript");

println!("Running pnpm publish in {}...", sdk_dir.display());
println!("Running npm release steps in {}...", sdk_dir.display());
println!("Note: prepublishOnly script will build, test, and size up the package");

// pnpm install first
Expand All @@ -52,25 +52,45 @@ impl NpmRelease {
return Err("Failed to run pnpm install".to_string());
}

let (step, step_err) = if self.dry_run {
("pnpm run prepublishOnly", "run prepublish build/test/size checks")
} else {
("pnpm publish", "publish package to npm")
};

let mut cmd = Command::new("pnpm");
// The publish step here runs from a directory that doesn't have a clean git worktree
// so we disable pnpm's default git cleanliness/branch checks otherwise this will fail.
// We need --no-git-checks because otherwise the workflow will complain that we're not
// on the main/master branch (we're in a detached HEAD state at this point).
// ERR_PNPM_GIT_UNKNOWN_BRANCH The Git HEAD may not attached to any branch, but your "publish-branch" is set to "master|main".
if self.dry_run {
cmd.args(["publish", "--dry-run", "--no-git-checks"]);
// Run the pre-publish build/test/size checks, then pack the tarball
// locally instead of uploading it.
cmd.args(["run", "prepublishOnly"]);
} else {
cmd.args(["publish", "--no-git-checks"]);
}
cmd.current_dir(sdk_dir);
util::print_command(&cmd);
let status = cmd
.status()
.map_err(|e| format!("Failed to execute pnpm publish: {}", e))?;
let status = cmd.status().map_err(|e| format!("Failed to execute {}: {}", step, e))?;

if !status.success() {
return Err("Failed to publish package to npm".to_string());
return Err(format!("Failed to {}", step_err));
}

if self.dry_run {
// Pack the dry-run tarball.
cmd = Command::new("pnpm");
cmd.arg("pack");
cmd.current_dir(sdk_dir);
util::print_command(&cmd);
let status = cmd
.status()
.map_err(|e| format!("Failed to execute pnpm pack: {}", e))?;
if !status.success() {
return Err("Failed to pack package".to_string());
}
}

println!(
Expand Down
Loading