Refactor logging, switch to zerolog, log structured objects, enable caller logging in debug#106
Open
jmunson wants to merge 1 commit intocloudflare:masterfrom
Open
Refactor logging, switch to zerolog, log structured objects, enable caller logging in debug#106jmunson wants to merge 1 commit intocloudflare:masterfrom
jmunson wants to merge 1 commit intocloudflare:masterfrom
Conversation
|
CI is failing since it uses vendoring and the added dependency hasn't been vendored. Do we still want to vendor dependencies? |
Contributor
Author
|
I updated the PR to update the vendored dependencies. I'll save the decision on moving away from vendored deps until later |
willbuckner
previously approved these changes
Jul 18, 2020
szechuen
previously approved these changes
Jul 20, 2020
szechuen
left a comment
szechuen
left a comment
There was a problem hiding this comment.
Second @willbuckner's suggestions, but otherwise lgtm
jmunson
changed the title
Contributor
Author
|
Pushed a rewritten commit to address Wills feedback |
…aller logging in debug This is decent sized refactor of all logging code. The "file" backend could still use more work, as it doesn't retain the calling spec. We still respect the configuration options to configure log level and json logging, though debug logging now enables logging where in the source code the log was emitted. All log messages have been lowercased for consistency, and log objects prefer snake_case for object names. Some redundant logging(where we log, then return an error to a function that logs it) has been removed.
szechuen
approved these changes
Jul 22, 2020
willbuckner
approved these changes
Jul 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is decent sized refactor of all logging code. The "file" backend could still use more work, as it doesn't retain the calling spec.
We still respect the configuration options to configure log level and json logging, though debug logging now enables logging where in the source code the log was emitted.
All log messages have been lowercased for consistency, and log objects prefer snake_case for object names.
Some redundant logging(where we log, then return an error to a function that logs it) has been removed.