fix(dropdown): limit dropdown content height to available viewport space#609
Open
invisal wants to merge 1 commit into
Open
fix(dropdown): limit dropdown content height to available viewport space#609invisal wants to merge 1 commit into
invisal wants to merge 1 commit into
Conversation
Contributor
Author
|
/bonk please review and approve |
mattrothenberg
approved these changes
Jul 1, 2026
Collaborator
|
/bonk review and approve |
commit: |
Contributor
Docs PreviewCommit: |
mattrothenberg
approved these changes
Jul 1, 2026
Contributor
There was a problem hiding this comment.
LGTM. Clean, minimal fix that follows the existing pattern used by Select, Combobox, and Autocomplete.
max-h-[var(--available-height)]is provided by Base UI'sPositioner— correct usage.- Demo naming follows convention and is properly wired into the docs page.
- Changeset included.
One tiny non-blocking observation: DropdownMenuContent still lacks a displayName, but that's pre-existing and not introduced by this PR.
| <DropdownMenuPrimitive.Popup | ||
| className={cn( | ||
| "overflow-hidden bg-kumo-control text-kumo-default", // background | ||
| "max-h-[var(--available-height)] overflow-y-auto", // limit height when list is too long and might go off screen |
Contributor
There was a problem hiding this comment.
The combination of overflow-hidden (line 120) and overflow-y-auto here results in overflow-x: hidden; overflow-y: auto, which correctly preserves rounded-corner clipping while enabling vertical scrolling. 👍
Contributor
|
Approved #609 — fix(dropdown): limit dropdown content height to available viewport space. Summary:
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


















This PR fixes an issue where dropdown content could exceed the available viewport height, causing content to be clipped and inaccessible. The dropdown now respects the viewport boundaries by limiting its maximum height to the available space.
Reviews
Tests