Handle custom ALPNs in s2n impl of ALPN::to_wire_protocols()#820
Open
varunravi98 wants to merge 1 commit intocloudflare:mainfrom
Open
Handle custom ALPNs in s2n impl of ALPN::to_wire_protocols()#820varunravi98 wants to merge 1 commit intocloudflare:mainfrom
varunravi98 wants to merge 1 commit intocloudflare:mainfrom
Conversation
johnhurt
added
the
Accepted
johnhurt
pushed a commit
that referenced
this pull request
Mar 2, 2026
johnhurt
pushed a commit
that referenced
this pull request
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should fix #818.
I modeled the fix to emulate what we have for
rustlsas I believe theprotocol()method forCustomshould allowto_wire_protocols()to return the custom protocol's name for the ALPN even on s2n.Please let me know if there are any issues with this or if you would like targeted testing. Thanks!