Skip to content

Bump adm-zip from 0.5.17 to 0.6.0 in /packages/telescope - #312

Closed
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/packages/telescope/adm-zip-0.6.0
Closed

Bump adm-zip from 0.5.17 to 0.6.0 in /packages/telescope#312
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/packages/telescope/adm-zip-0.6.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jul 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Bumps adm-zip from 0.5.17 to 0.6.0.

Release notes

Sourced from adm-zip's releases.

v0.6.0

Full Changelog: cthackers/adm-zip@v0.5.18...v0.6.0

This release fixes a security vulnerability (CVE-2026-39244), resolves several long-standing bugs, ships built-in TypeScript types, and includes two behavior changes worth reading before you upgrade.

  • extractEntryTo(dirEntry, target, maintainEntryPath = false) now preserves subdirectories instead of flattening files into the target folder by basename (which also silently overwrote same-named files). (#306)
  • Extraction no longer fails when the modification time can't be set — utimes is now best-effort. (#379)
  • Minimum Node.js is now 14 (the code already required it; engines was incorrectly >=12).
  • CVE-2026-39244 — a crafted archive declaring a huge uncompressed size could force an unbounded Buffer.alloc and OOM the process; allocation is now bounded by the data actually present. Reported by Daniel Púa (devploit), Anh Hong, and José Antonio Zamudio Amaya. (#568)
  • Hardened entry-name lookup against object injection (proto names). Prototype-less table.
  • Data-descriptor regression rejecting valid archives (#548, #533, #554)
  • Directory permissions not restored on extract (#530)
  • Infinite recursion on symlink loops in addLocalFolder (#541)
  • Uncaught process crash in writeFileToAsync on write failure (#470, #459, #402)
  • Empty name on directory entries (#466)
  • test() always returned false for archives with files
  • ~6× faster entry sorting for large archives
  • Built-in TypeScript definitions (types.d.ts) — you can drop @​types/adm-zip

v0.5.18

What's Changed

New Contributors

Full Changelog: cthackers/adm-zip@v0.5.17...v0.5.18

Changelog

Sourced from adm-zip's changelog.

0.6.0 / 2026-07-10

Security

  • Fixed CVE-2026-39244: a crafted archive declaring a huge uncompressed size could force an unbounded Buffer.alloc (memory exhaustion / DoS) before any validation. Allocation is now bounded by the data actually present — STORED output is sized from the real bytes, DEFLATED output is grown by the inflater and capped at the declared size (#568)
  • Hardened the internal entry-name lookup table against object injection: entry names come from untrusted archives, and a name such as __proto__ previously resolved to Object.prototype, crashing addFile and hiding the entry from getEntry/readFile. The table is now prototype-less

Bug fixes

  • Fixed a regression (0.5.15) that rejected valid archives using a data descriptor (general-purpose bit 3). The payload is now validated against the authoritative central-directory CRC instead of requiring/parsing the trailing descriptor (#548, #533, #554)
  • Fixed extractAllTo/extractAllToAsync not restoring directory permissions with keepOriginalPermission; directory modes are applied after their contents are written, deepest path first, and no longer lock the extractor out of a restrictive directory (#530)
  • Fixed infinite recursion in addLocalFolder when a folder contains a symlink pointing back to an ancestor (e.g. workspace node_modules); the walk now tracks resolved real paths and skips already-visited directories (#541)
  • Fixed an uncaught exception (ERR_INVALID_ARG_TYPE) that crashed the process when writeFileToAsync could not open the target file (bad permissions, invalid filename, exhausted file descriptors); write failures are now reported through the callback and write errors are no longer silently swallowed (#470, #459, #402)
  • Fixed directory entries reporting an empty name (e.g. a/b/c/ now returns c) (#466)
  • Fixed extractEntryTo flattening subdirectories when maintainEntryPath is false; the structure below the extracted directory is now preserved instead of collapsing (and overwriting) files by basename (#306)
  • Fixed a failed utimes aborting extraction; setting the modification time is now best-effort and never fails extraction of already-written content (#379)
  • Fixed test() always returning false for any archive containing a file (it indexed the entries array with an entry object instead of reading the entry); it now correctly verifies each entry's CRC

Performance

  • Faster entry sorting when writing archives with many entries: names are decoded once instead of on every comparison (about 6× faster sort for large archives)

Added

  • Bundled TypeScript type definitions (types.d.ts), so @types/adm-zip is no longer required

Notes

  • Behavior change: extractEntryTo(dir, target, /* maintainEntryPath */ false) now preserves subdirectories beneath the extracted directory rather than flattening them
  • Behavior change: extraction no longer fails when the modification time cannot be set

0.5.4 / 2021-03-08

  • Fixed relative paths
  • Added zipcrypto encryption
  • Lower verMade for macOS when generating zip file

0.5.3 / 2021-02-07

  • Fixed filemode when unzipping

0.5.2 / 2021-01-27

  • Fixed path traversal issue (GHSL-2020-198)

0.5.1 / 2020-11-27

  • Incremented version (cthackers)
  • Fixed outFileName (cthackers)

0.5.0 / 2020-11-19

  • Added extra parameter to extractEntryTo so target filename can be renamed (cthackers)

... (truncated)

Commits
  • 2b4d840 updated minimum node engine version to >= 14
  • dc57f0f Hardened entry-name lookup, fixed test(), and sped up entry sorting
  • f81806a Made utimes best-effort so it can't abort extraction (#379)
  • ab04324 Fixed extractEntryTo flattening subdirectories (#306)
  • 8a5d9ba Fixed empty name for directory entries (#466)
  • 3e72790 Fixed uncaught crash in writeFileToAsync on write failure (#470, #459, #402)
  • 651ae4c Added typescript types
  • e72021d Fixed infinite recursion on symlink loops in addLocalFolder (#541)
  • 8f3176b Fixed directory permissions on linux
  • 4d2c8f9 Fixed error introduced with zip descriptor checks
  • Additional commits viewable in compare view

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Jul 18, 2026
@sufian-cf

sufian-cf commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

@dependabot recreate

@dependabot
Bump adm-zip from 0.5.17 to 0.6.0 in /packages/telescope
0e44f57 
Bumps [adm-zip](https://github.com/cthackers/adm-zip) from 0.5.17 to 0.6.0.
- [Release notes](https://github.com/cthackers/adm-zip/releases)
- [Changelog](https://github.com/cthackers/adm-zip/blob/master/history.md)
- [Commits](cthackers/adm-zip@v0.5.17...v0.6.0)

---
updated-dependencies:
- dependency-name: adm-zip
  dependency-version: 0.6.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/packages/telescope/adm-zip-0.6.0 branch from b12200d to 0e44f57 Compare July 24, 2026 17:58
@sufian-cf sufian-cf mentioned this pull request Jul 24, 2026
Merged
sufian-cf added a commit that referenced this pull request Jul 24, 2026
@sufian-cf
Fix package-lock.json, patch version bump due to some dependency upgr…
db626bf 
…ades (CVEs) (#336)

* Fixed lockfiles

This is a package with workspaces, so we only need one package-lock.json
file at the root. This change has deleted and recreated the
package-lock.json files at the repo root.

* Apply Dependabot security bumps for adm-zip, ejs and eslint

Pulls the package.json upgrades from the open Dependabot security PRs into
packages/telescope, consolidated into a single change now that the repo has
one lockfile at the root.

Applied from Dependabot:

- adm-zip ^0.5.16 -> ^0.6.0, fixing CVE-2026-39244, where a crafted archive
  declaring a huge uncompressed size could force an unbounded Buffer.alloc
  and exhaust memory (#313)
- ejs ^3.1.10 -> ^6.0.1 and eslint ^9.39.2 -> ^10.7.0, the ancestor bumps
  required to clear the brace-expansion advisory; the three vulnerable
  brace-expansion 1.1.16 copies all sit under eslint 9's tree (#314)

Three further changes were needed to keep the tree installable, none of
which Dependabot included:

- Add @eslint/js ^10.0.1 as an explicit devDependency. eslint.config.js
  imports it directly but never declared it, relying on eslint 9 pulling it
  in transitively. eslint 10 no longer depends on it, so lint would fail on
  an unresolved import.
- Bump @typescript-eslint/eslint-plugin and @typescript-eslint/parser to
  ^8.65.0. The 8.54 peer range is eslint ^8.57 || ^9, so eslint 10 would
  fail to resolve. 8.65 widens it to include ^10, and its typescript peer
  still covers our ^5.9.3.
- Drop @types/adm-zip. adm-zip 0.6.0 ships its own types.d.ts, which
  TypeScript prefers over @types, leaving the DefinitelyTyped package as
  dead weight describing the old API.

Supersedes and closes the remaining Dependabot PRs:

- #312 duplicates #313, differing only in writing the deleted nested
  packages/telescope/package-lock.json
- #318 is a strict subset of #314, omitting the ejs bump
- #332 changes only the deleted nested lockfile; postcss already resolves
  to 8.5.23 through vite in the regenerated root lockfile
- #315 is a downgrade, rewriting astro ^7.1.3 back to ^7.1.0 against a base
  predating #331

* Minor version bump for dependencies/CVE fixes

* Fix lint violations from new eslint 10 recommended rules

eslint 10 adds a few new errors, which surfaced 8 pre-existing problems

This fixes those issues.

* Run PR tests from the workspace root and add a lint step

Now that package-lock.json is consolidated, this repairs the PR tests:

- Commands are run from the workspace root
- A new "lint" step is performed, so we catch lint issues in CI

* Point deploy workflows at root lockfile

Now that lockfiles are consolidated, install step now runs at repo root.

* Fix test failure introduced by upgrading astro to v7

The astro compiler changed (golang to rust), which rejects unmatched brace tracking.

This change escapes the stray closing brace with `&rcub;`.

* Bump docker image to match packages

* Keep playwright in sync

* Add package-lock.json for playwright sync

* Keep playwright in sync with 1.61.1

* Fix missing 1.61.1 playwright versions
@dependabot @github

dependabot Bot commented on behalf of github Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

Looks like adm-zip is up-to-date now, so this is no longer needed.

@dependabot dependabot Bot closed this Jul 24, 2026
@dependabot
dependabot Bot deleted the dependabot/npm_and_yarn/packages/telescope/adm-zip-0.6.0 branch July 24, 2026 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sufian-cf