BREAKING: Implement more of the R2 API#627
Draft
fisherdarling wants to merge 2 commits intocloudflare:mainfrom
Draft
BREAKING: Implement more of the R2 API#627fisherdarling wants to merge 2 commits intocloudflare:mainfrom
fisherdarling wants to merge 2 commits intocloudflare:mainfrom
Conversation
guybedford
reviewed
Jun 17, 2025
Collaborator
guybedford
left a comment
guybedford
left a comment
There was a problem hiding this comment.
This seems sensible to me and breaking changes like this are okay to make in major releases.
It would of course be nice to see tests though.
This commit adds missing `Conditional` operations to the R2 `PutOptionsBuilder`. This is a breaking change, because after this change, an R2 put may return `None`.
This adds the `startAfter` list option which is implemented, however undocumented. This is equivalent to the `marker` field in the s3 api.
fisherdarling
force-pushed
the
fisher/put-options-onlyif
branch
from
c4944c0 to
87cf79e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two missing parts of the R2 API:
startAfteroption in R2's list objects callnull, orNonein Rust. The returned object from a PUT is not aOption<Object>.This API is successfully being used to implement a compare-and-swap (CAS) primitive for an internal project. We ended up not needing the list changes, but I thought it'd be useful nonetheless.
Tasks: