Skip to content

Updated getAccessToken to respect AbortSignal and timeout correctly#12660

Open
hhoughgg wants to merge 1 commit intocloudflare:mainfrom
hhoughgg:access-token-async
Open

Updated getAccessToken to respect AbortSignal and timeout correctly#12660
hhoughgg wants to merge 1 commit intocloudflare:mainfrom
hhoughgg:access-token-async

Conversation

@hhoughgg
Copy link
Contributor

@hhoughgg hhoughgg commented Feb 24, 2026

getAccessToken used spawnSync that stops abort signals being received and seems to timeout forever if you never make it to the accept page for access.

  • Tests
    • [ x] Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • [ x] Documentation not necessary

Open with Devin

@hhoughgg hhoughgg requested a review from a team as a code owner February 24, 2026 04:13
@changeset-bot
Copy link

changeset-bot bot commented Feb 24, 2026

⚠️ No Changeset found

Latest commit: 42945f1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional findings.

Open in Devin Review

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 24, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12660

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12660

miniflare

npm i https://pkg.pr.new/miniflare@12660

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12660

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12660

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12660

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12660

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12660

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@12660

wrangler

npm i https://pkg.pr.new/wrangler@12660

commit: 42945f1

…ute to stop terminal hang on failed access login
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

1 participant