Skip to content

refactor(miniflare): centralize internal paths and move platform proxy endpoint#12686

Open
edmundhung wants to merge 4 commits intomainfrom
edmundhung/refactor-platform-proxy-api
Open

refactor(miniflare): centralize internal paths and move platform proxy endpoint#12686
edmundhung wants to merge 4 commits intomainfrom
edmundhung/refactor-platform-proxy-api

Conversation

@edmundhung
Copy link
Member

@edmundhung edmundhung commented Feb 26, 2026

Fixes n/a.

This is just an internal refactor to centralize all our /cdn-cgi paths. No behavior changes.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: refactor only

A picture of a cute animal (not mandatory, but encouraged)


Open with Devin

@edmundhung edmundhung requested a review from a team as a code owner February 26, 2026 17:09
@changeset-bot
Copy link

changeset-bot bot commented Feb 26, 2026

🦋 Changeset detected

Latest commit: dcd3868

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@claude
Copy link
Contributor

claude bot commented Feb 26, 2026

Claude encountered an error —— View job


Changeset Review

  • Read changeset guidelines
  • Review .changeset/brave-planes-dance.md
  • Validate against criteria
  • Check image attachment
  • Provide feedback

devin-ai-integration[bot]

This comment was marked as resolved.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 26, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12686

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12686

miniflare

npm i https://pkg.pr.new/miniflare@12686

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12686

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12686

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12686

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12686

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12686

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@12686

wrangler

npm i https://pkg.pr.new/wrangler@12686

commit: ac266ff

@edmundhung edmundhung force-pushed the edmundhung/refactor-platform-proxy-api branch from 9dd796d to 88422f3 Compare February 26, 2026 17:20
devin-ai-integration[bot]

This comment was marked as resolved.

@edmundhung edmundhung self-assigned this Feb 27, 2026
@edmundhung edmundhung force-pushed the edmundhung/refactor-platform-proxy-api branch from 18201cf to c54485a Compare February 27, 2026 12:57
@edmundhung edmundhung force-pushed the edmundhung/refactor-platform-proxy-api branch from c54485a to dcd3868 Compare March 2, 2026 14:14
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2026

⚠️ Issues found

.changeset/brave-planes-dance.md

Issue 1: Version type may be incorrect

The changeset is marked as patch, but it describes moving the getPlatformProxy magic proxy endpoint from the root URL to /cdn-cgi/platform-proxy. This is a behavioral change — any code that depends on the old proxy path will break.

Per the README:

  • patch is for bug fixes and small improvements
  • minor is appropriate for changes to experimental/beta features, even if they are breaking

If this endpoint path is considered internal/experimental, this should be minor per the guidelines: "changes to experimental/beta/pre-1.0 features (including breaking changes to those features)".

If the old path was never documented or intended to be user-facing, the patch bump needs a clarifying note in the description explaining why this is not a breaking change for users.

Issue 2: Changelog description quality

The title starts with refactor: — the README's bad examples explicitly call out "refactor" as insufficient without explaining user impact. While the body does provide some context, the description reads more as an internal implementation note than a user-facing changelog entry.

Specifically:

  • What does CorePaths constant mean to users? That's an internal detail.
  • What is the user impact of the endpoint move? Will existing integrations break?
  • If this is purely internal with no user-facing impact, a changeset may not be required at all (per README: "Changes that are purely internal refactoring with no user-facing impact" do not need a changeset).

Recommendation: Either:

  1. Clarify that this is user-facing, upgrade to minor, and rewrite the description to explain the impact to users (e.g., any code calling the old proxy path needs to be updated), or
  2. Clarify this is purely internal with no user-facing impact and remove the changeset entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

1 participant