[wrangler] serialize custom build watch events to avoid concurrent runs#12704
Open
dhruv7539 wants to merge 2 commits intocloudflare:mainfrom
Open
[wrangler] serialize custom build watch events to avoid concurrent runs#12704dhruv7539 wants to merge 2 commits intocloudflare:mainfrom
dhruv7539 wants to merge 2 commits intocloudflare:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 8ae0df1 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Author
|
Addressed both actionable comments in the latest push (8ae0df1):\n- fixed wiring in custom-build path to use \n- added a Wrangler patch changeset () |
Author
|
Addressed both actionable comments in the latest push (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BundlerControllerWhy
Fixes the behavior in #10944 where rapid multi-file changes can start multiple custom builds at once.
Testing
pnpm -C packages/wrangler test src/__tests__/api/startDevWorker/BundleController.test.tspnpm -C packages/wrangler exec eslint src/api/startDevWorker/BundlerController.ts src/__tests__/api/startDevWorker/BundleController.test.tsAdded regression test
custom build watcher changes are processed without concurrent custom buildsCustom build failedevents are emitted