chore: replace glob with tinyglobby#12705
Open
roli-lpci wants to merge 2 commits intocloudflare:mainfrom
Open
Conversation
🦋 Changeset detectedLatest commit: 6c97c1c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
emily-shen
reviewed
Mar 2, 2026
Contributor
emily-shen
left a comment
emily-shen
left a comment
There was a problem hiding this comment.
since this is used across a few packages, should we set the version in pnpm catalog?
Replace the `glob` package with the lighter `tinyglobby` across tools, create-cloudflare, and pages-shared packages. This aligns the rest of the monorepo with vite-plugin-cloudflare, which already uses tinyglobby. - tools: replace glob@11 with tinyglobby in e2e runner and deployment validation scripts - create-cloudflare: replace glob@10 with tinyglobby in build script - pages-shared: remove unused glob devDependency tinyglobby has fewer dependencies (2 vs 17+ for globby/fast-glob) and returns POSIX paths by default. Addresses cloudflare#11854 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
roli-lpci
force-pushed
the
chore/replace-glob-with-tinyglobby
branch
from
24991c6 to
6c97c1c
Compare
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the
globpackage withtinyglobbyacross tools, create-cloudflare, and pages-shared. This aligns the rest of the monorepo withvite-plugin-cloudflare, which already uses tinyglobby.Changes
globIterateSyncfrom glob withglobSyncfrom tinyglobbyglob.sync()withglobSyncfrom tinyglobbyWhy tinyglobby
posix: trueoptionTesting
pnpm check:type -F @cloudflare/tools— passpnpm check:type -F create-cloudflare— passpnpm check:type -F @cloudflare/pages-shared— passpnpm check:lint -F @cloudflare/tools— pass (0 warnings)pnpm check:lint -F create-cloudflare— pass (0 warnings)pnpm check:lint -F @cloudflare/pages-shared— pass (0 warnings)pnpm test:ci -F @cloudflare/tools— 75 tests passedpnpm test:ci -F create-cloudflare— 219 tests passedpnpm test:ci -F @cloudflare/pages-shared— 46 tests passedAddresses #11854