Skip to content

[create-cloudflare] Enable upload_source_maps by default for new projects#12741

Draft
penalosa wants to merge 1 commit intomainfrom
devin/1772540366-upload-source-maps-central
Draft

[create-cloudflare] Enable upload_source_maps by default for new projects#12741
penalosa wants to merge 1 commit intomainfrom
devin/1772540366-upload-source-maps-central

Conversation

@penalosa
Copy link
Contributor

@penalosa penalosa commented Mar 3, 2026

Supersedes #11726.

Instead of adding upload_source_maps: true to each of the 43 individual template wrangler.jsonc files, this sets it centrally in the updateWranglerConfig function — the same place that already sets name, compatibility_date, observability, and nodejs_compat for all C3 templates.

Like nodejs_compat, upload_source_maps is skipped for Python projects.

Key review points

  • TOML vs JSON behavior difference: For TOML configs, ??= is used (won't override if already set). For JSON configs, appendJSONProperty (which calls assign) is used (will override). This matches the existing pattern for observability vs nodejs_compat but is worth verifying is intentional.
  • Python exclusion: upload_source_maps is grouped with nodejs_compat inside the lang !== "python" guard. The original PR Set upload_source_maps to true for all C3 templates #11726 also removed it from Python templates explicitly.

Link to Devin session: https://app.devin.ai/sessions/9aa9987751da4a5b8ed3cf97a28996f5
Devin PR requested by @penalosa


…ects

Add upload_source_maps: true to the central updateWranglerConfig function
so all C3 templates get source maps enabled without needing per-template
changes. Skipped for Python projects.

Co-Authored-By: smacleod <samuel@macleod.space>
@changeset-bot
Copy link

changeset-bot bot commented Mar 3, 2026

🦋 Changeset detected

Latest commit: c5dc447

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@devin-ai-integration
Copy link
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

✅ All changesets look good

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 3, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12741

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12741

miniflare

npm i https://pkg.pr.new/miniflare@12741

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12741

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12741

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12741

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12741

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12741

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@12741

wrangler

npm i https://pkg.pr.new/wrangler@12741

commit: b5685ee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

1 participant