Skip to content

feat: replace fork IT trigger comment with pull_request_target approval gate - #154

Merged
stephanme merged 1 commit into
mainfrom
fork-pr-validation
Aug 6, 2026
Merged

feat: replace fork IT trigger comment with pull_request_target approval gate#154
stephanme merged 1 commit into
mainfrom
fork-pr-validation

Conversation

@stephanme

Copy link
Copy Markdown
Member

Fork PRs now automatically trigger integration test workflows on each push. A lightweight gate job pauses execution pending approval by a committer via the fork-pr-integration-test GitHub environment. Same-repo PRs skip the gate and run tests immediately.

Removes the fork-integration-trigger.yml workflow and report-fork-status action, both of which were only needed for the old dispatch-based approach.

…al gate

Fork PRs now automatically trigger integration test workflows on each
push. A lightweight gate job pauses execution pending approval by a
committer via the fork-pr-integration-test GitHub environment. Same-repo
PRs skip the gate and run tests immediately.

Removes the fork-integration-trigger.yml workflow and report-fork-status
action, both of which were only needed for the old dispatch-based
approach.
@stephanme

Copy link
Copy Markdown
Member Author

Proposal by @FloThinksPi

Makes things simpler using standard Github features (pull_request_target trigger + environment gate): no magic comment that you have to remember, no extra status reporting with duplicated checks (skipped and green ones).

@stephanme

Copy link
Copy Markdown
Member Author

ITs don't run because there is a bootstrapping problem. Here's what happens with this PR open:

  • pull_request event fires → GitHub looks for pull_request trigger in the HEAD branch's workflow files → the HEAD branch already has pull_request_target (not pull_request) → no match, ITs don't run
  • pull_request_target event fires → GitHub always looks at the BASE branch (main) for the workflow files → main still has the old pull_request trigger → no match, ITs don't run

Neither trigger fires because this PR is changing the trigger itself. Once it merges to main, future PRs will work correctly.

To run ITs for this PR's changes, use workflow_dispatch to manually trigger each IT workflow from the fork-pr-validation branch. But this won't update the required status checks.

To handle this, a repo admin can temporarily allow admins to bypass the branch protection rules and then merge the PR.

@stephanme

Copy link
Copy Markdown
Member Author

Ran manually the DAV Integration Tests.
They succeeded and the gate was ignored (no fork PR).

@github-project-automation github-project-automation Bot moved this from Inbox to Pending Merge | Prioritized in Foundational Infrastructure Working Group Aug 6, 2026
@stephanme
stephanme merged commit 1b0f71a into main Aug 6, 2026
6 checks passed
@github-project-automation github-project-automation Bot moved this from Pending Merge | Prioritized to Done in Foundational Infrastructure Working Group Aug 6, 2026
@stephanme

Copy link
Copy Markdown
Member Author

Merged bypassing the missing ITs (see comment above).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants