fix(azure): require storage account for explicit credentials #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armru
previously approved these changes
Dec 30, 2025
armru
approved these changes
Dec 30, 2025
Signed-off-by: Marco Nenciarini <[email protected]>
Signed-off-by: Armando Ruocco <[email protected]>
Signed-off-by: Marco Nenciarini <[email protected]>
NiccoloFei
force-pushed
the
dev/azure-require-storage-account
branch
from
41b3b88 to
340bb48
Compare
Signed-off-by: Niccolò Fei <[email protected]>
NiccoloFei
approved these changes
Dec 30, 2025
This commit fixes a duplicate test that was incorrectly testing DataBackupConfiguration instead of WalBackupConfiguration, adds proper coverage for WAL backup configuration methods, and includes missing tests for Azure AD authentication while removing a redundant connection string validation test. Signed-off-by: Marco Nenciarini <[email protected]>
mnencia
added a commit
to cloudnative-pg/cloudnative-pg
that referenced
this pull request
Dec 31, 2025
This change fixes Azure credentials validation to require storage account when using explicit credentials such as storage key or SAS token, and ensures connection string is mutually exclusive with other authentication parameters. Related: cloudnative-pg/barman-cloud#177 Signed-off-by: Marco Nenciarini <[email protected]>
mnencia
added a commit
to cloudnative-pg/plugin-barman-cloud
that referenced
this pull request
Dec 31, 2025
This change fixes Azure credentials validation to require storage account when using explicit credentials such as storage key or SAS token, and ensures connection string is mutually exclusive with other authentication parameters. Related: cloudnative-pg/barman-cloud#177 Signed-off-by: Marco Nenciarini <[email protected]>
mnencia
added a commit
to cloudnative-pg/cloudnative-pg
that referenced
this pull request
Jan 7, 2026
This change fixes Azure credentials validation to require storage account when using explicit credentials such as storage key or SAS token, and ensures connection string is mutually exclusive with other authentication parameters. Related: cloudnative-pg/barman-cloud#177 Signed-off-by: Marco Nenciarini <[email protected]>
mnencia
added a commit
to cloudnative-pg/cloudnative-pg
that referenced
this pull request
Jan 8, 2026
This change fixes Azure credentials validation to require storage account when using explicit credentials such as storage key or SAS token, and ensures connection string is mutually exclusive with other authentication parameters. Related: cloudnative-pg/barman-cloud#177 Signed-off-by: Marco Nenciarini <[email protected]>
mnencia
added a commit
to cloudnative-pg/plugin-barman-cloud
that referenced
this pull request
Jan 8, 2026
This change fixes Azure credentials validation to require a storage account when using explicit credentials such as a storage key or SAS token, and ensures the connection string is mutually exclusive with other authentication parameters. Closes #705 Related: cloudnative-pg/barman-cloud#177 Signed-off-by: Marco Nenciarini <[email protected]>
mnencia
added a commit
to cloudnative-pg/cloudnative-pg
that referenced
this pull request
Jan 8, 2026
This change fixes Azure credentials validation to require a storage account when using explicit credentials such as a storage key or SAS token, and ensures the connection string is mutually exclusive with other authentication parameters. Closes #9598 Related: cloudnative-pg/barman-cloud#177 Signed-off-by: Marco Nenciarini <[email protected]>
cnpg-bot
pushed a commit
to cloudnative-pg/cloudnative-pg
that referenced
this pull request
Jan 8, 2026
This change fixes Azure credentials validation to require a storage account when using explicit credentials such as a storage key or SAS token, and ensures the connection string is mutually exclusive with other authentication parameters. Closes #9598 Related: cloudnative-pg/barman-cloud#177 Signed-off-by: Marco Nenciarini <[email protected]> (cherry picked from commit 53dc521)
cnpg-bot
pushed a commit
to cloudnative-pg/cloudnative-pg
that referenced
this pull request
Jan 8, 2026
This change fixes Azure credentials validation to require a storage account when using explicit credentials such as a storage key or SAS token, and ensures the connection string is mutually exclusive with other authentication parameters. Closes #9598 Related: cloudnative-pg/barman-cloud#177 Signed-off-by: Marco Nenciarini <[email protected]> (cherry picked from commit 53dc521)
cnpg-bot
pushed a commit
to cloudnative-pg/cloudnative-pg
that referenced
this pull request
Jan 8, 2026
This change fixes Azure credentials validation to require a storage account when using explicit credentials such as a storage key or SAS token, and ensures the connection string is mutually exclusive with other authentication parameters. Closes #9598 Related: cloudnative-pg/barman-cloud#177 Signed-off-by: Marco Nenciarini <[email protected]> (cherry picked from commit 53dc521)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.