fix(targetTime): treat RFC3339-like timestamps without timezone as UTC #700
+9
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:S
|
👍 looks good, will upvote once the pseudo-version can be discarded |
armru
previously approved these changes
Dec 29, 2025
NiccoloFei
previously approved these changes
Dec 29, 2025
Update the machinery dependency to include the fix that ensures RFC3339-like timestamps without timezone (e.g., "2024-01-15T10:30:00") are interpreted as UTC. The documentation has been updated to use a targetTime example with an explicit Z suffix and to clarify that timestamps without timezone are interpreted as UTC. Closes #699 Signed-off-by: Marco Nenciarini <[email protected]>
Signed-off-by: Armando Ruocco <[email protected]>
dosubot
bot
added
size:XS
armru
approved these changes
Dec 29, 2025
jsilvela
approved these changes
Dec 30, 2025
mnencia
added a commit
that referenced
this pull request
Dec 30, 2025
Follow-up to #700 to align the targetTime documentation with cloudnative-pg standards. The note now covers all timestamp formats (not just RFC 3339) and uses PostgreSQL format in the example to avoid advertising the non-standard RFC3339-like format without timezone. A warning has been added recommending to always specify an explicit timezone to avoid ambiguity. Related: #699 Signed-off-by: Marco Nenciarini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the machinery dependency to include the fix that ensures RFC3339-like timestamps without timezone (e.g., "2024-01-15T10:30:00") are interpreted as UTC.
The documentation has been updated to use a targetTime example with an explicit Z suffix and to clarify that RFC3339-like timestamps without timezone are interpreted as UTC.
Closes #699