Add support for Python 3.12 and drop EOL 3.6 and 3.7#514
Closed
hugovk wants to merge 4 commits intocloudpipe:masterfrom
Closed
Add support for Python 3.12 and drop EOL 3.6 and 3.7#514hugovk wants to merge 4 commits intocloudpipe:masterfrom
hugovk wants to merge 4 commits intocloudpipe:masterfrom
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #514 +/- ##
==========================================
- Coverage 83.28% 81.89% -1.39%
==========================================
Files 4 4
Lines 718 674 -44
Branches 157 148 -9
==========================================
- Hits 598 552 -46
- Misses 95 109 +14
+ Partials 25 13 -12
☔ View full report in Codecov by Sentry. |
ogrisel
approved these changes
Oct 9, 2023
Contributor
ogrisel
left a comment
ogrisel
left a comment
There was a problem hiding this comment.
Thanks for the clean-up. This looks good to me. The only problem is the flake8 diff failure, but it looks unrelated to this. Let me try to investigate.
Contributor
|
I found more code to clean-up based on the test coverage report. This work is ongoing at # #517. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The second Python 3.12 release candidate is out! 🚀
See also https://dev.to/hugovk/help-test-python-312-beta-1508/
Python 3.6 and 3.7 are EOL and no longer receiving security updates (or any updates) from the core Python team.
https://devguide.python.org/versions/