fix(comments-sidebar): expand player in cinema mode with sidebar layout#3975
Open
Vaibhav-Chodankar wants to merge 1 commit into
Open
Conversation
Treat ImprovedTube cinema mode like theater/fullscreen so inline player widths are cleared and the sidebar no longer reserves empty space. Fixes code-charity#3973 Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
|
thank you very much! @Vaibhav-Chodankar can be shorter and or more conditional and or solve more issues at once compare: #3958 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
it-cinema-modehtml attribute and trigger layout recalculation on toggleRelated issue
Fixes #3973
Test plan
npm test -- tests/unit/comments-sidebar.test.js