fix: remove unused custom encryption helpers#3993
Open
alextyang wants to merge 1 commit into
Open
Conversation
alextyang
changed the title
Collaborator
|
( satus.js is only loaded with our GUI yet ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
satusdefines AES-GCM encrypt/decrypt helpers that are not referenced anywhere in the extension. Their presence complicates the App Store encryption declaration and international compliance even though the shipped app does not need custom encryption.Root cause
The helpers appear to be dead utility code. Keeping unused encryption code in the shipped extension makes the App Store review path harder to explain without adding runtime value.
Fix
Remove the unused custom encryption helpers instead of documenting encryption that the app does not actually use.
If the project wants to keep these helpers for future use or another browser-specific path, this can be adjusted, but the current extension does not reference them.
Validation
Searched for references and confirmed AES-GCM is absent from the packaged extension.