fix(plugin): guard against undefined step.name in retryFailedStep#5562
Closed
gololdf1sh wants to merge 1 commit into
Closed
fix(plugin): guard against undefined step.name in retryFailedStep#5562gololdf1sh wants to merge 1 commit into
gololdf1sh wants to merge 1 commit into
Conversation
a0599c8 to
7a96d61
Compare
This was referenced May 14, 2026
Author
|
Root-cause fix: #5564 Instead of patching the plugin with a fallback, this renames |
Replace step.name with step.title — after the Step.name → Step.title rename (codeceptjs#5564), step.title is the canonical field on both full Step objects and simplified ones from worker IPC. Closes testomatio/e2e-tests#139 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
7a96d61 to
60f4960
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
retryFailedStepplugin crashes workers inrun-workersmode:The plugin reads
step.name, but in worker mode steps are serialized viasimplify()which dropsname.Fix
Replace
step.name→step.titlein the plugin. Depends on #5564 which renamesStep.name→Step.titleacross core.Related
Step.name→Step.title