Skip to content

⚡️ Speed up function _is_unrequested_hidden_file_or_is_inside_unrequested_hidden_dir by 11% #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function _is_unrequested_hidden_file_or_is_inside_unrequested_hidden_dir by 11% #125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions src/datasets/data_files.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,13 +242,20 @@ def _is_unrequested_hidden_file_or_is_inside_unrequested_hidden_dir(matched_rel_
# We just need to check if every hidden part from the path is present explicitly in the pattern.
# Since we assume that the path matches the pattern, it's equivalent to counting that both
# the path and the pattern have the same number of hidden parts.
hidden_directories_in_path = [
part for part in PurePath(matched_rel_path).parts if part.startswith(".") and not set(part) == {"."}
]
hidden_directories_in_pattern = [
part for part in PurePath(pattern).parts if part.startswith(".") and not set(part) == {"."}
]
return len(hidden_directories_in_path) != len(hidden_directories_in_pattern)
hidden_directories_in_path = 0
for part in PurePath(matched_rel_path).parts:
# part.startswith(".") and not set(part) == {"."}
# Use part.strip('.') != '' to avoid allocating a set for parts that are only dots.
if part.startswith(".") and part.strip(".") != "":
hidden_directories_in_path += 1

hidden_directories_in_pattern = 0
for part in PurePath(pattern).parts:
# part.startswith(".") and not set(part) == {"."}
if part.startswith(".") and part.strip(".") != "":
hidden_directories_in_pattern += 1

return hidden_directories_in_path != hidden_directories_in_pattern


def _get_data_files_patterns(pattern_resolver: Callable[[str], list[str]]) -> dict[str, list[str]]:
Expand Down