Skip to content

feat: Add join tokens for trust zone servers#167

Draft
alec-w wants to merge 2 commits intomainfrom
add-join-tokens-for-trust-zone-servers
Draft

feat: Add join tokens for trust zone servers#167
alec-w wants to merge 2 commits intomainfrom
add-join-tokens-for-trust-zone-servers

Conversation

@alec-w
Copy link
Copy Markdown
Contributor

@alec-w alec-w commented Jan 25, 2026

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 25, 2026

The latest Buf updates on your PR. Results from workflow buf-ci / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedFeb 3, 2026, 10:58 PM

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @alec-w, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new capability to the Trust Zone Server service, allowing the creation of temporary join tokens. These tokens provide a flexible and secure mechanism for Trust Zone Servers to register with the Connect platform, especially in situations where traditional server verification might be challenging. The changes span protobuf definitions, generated code for Go and TypeScript, and updates to both real and fake client implementations to fully integrate this new feature.

Highlights

  • New RPC Method: A new RPC method, CreateJoinToken, has been added to the TrustZoneServerService. This method allows for the generation of temporary tokens that Trust Zone Servers can use to register with the Connect system.
  • Protobuf Definitions: New protobuf messages, CreateJoinTokenRequest and CreateJoinTokenResponse, have been defined to support the new CreateJoinToken RPC. These definitions include the trust_zone_server_id for the request and the join_token for the response.
  • Client and Server Implementations: The Go and TypeScript client and server interfaces and implementations for the TrustZoneServerService have been updated to include the new CreateJoinToken method. This ensures that the new functionality is exposed and handled correctly across the service.
  • Fake Client Support: The fake client implementation (fakeconnect.go and fake.go) has been extended to support the CreateJoinToken method, including the storage of generated join tokens, which is crucial for testing and development environments.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the functionality to create join tokens for trust zone servers. The changes are well-implemented across the protobuf definitions, generated code, client, and tests. The code quality is high and the new feature is well-tested. I have one minor suggestion for improving the fake client implementation.

Comment thread pkg/connect/client/trustzoneserver/v1alpha1/fake/fake.go
@alec-w alec-w force-pushed the add-join-tokens-for-trust-zone-servers branch from f03aacf to 5f0b670 Compare February 3, 2026 22:39
@alec-w alec-w force-pushed the add-join-tokens-for-trust-zone-servers branch from 5f0b670 to ebab96f Compare February 3, 2026 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant