feat: added Noves Intents action provider#762
Open
marianowadinoves wants to merge 1 commit intocoinbase:mainfrom
Open
feat: added Noves Intents action provider#762marianowadinoves wants to merge 1 commit intocoinbase:mainfrom
marianowadinoves wants to merge 1 commit intocoinbase:mainfrom
Conversation
🟡 Heimdall Review Status
|
github-actions
bot
added
documentation
Contributor
|
Hi @marianowadinoves, thanks for your contribution! Could you please rebase against main, then I will do some testing. A few initial comments below |
Contributor
|
It would be great if you could include the result of some manual end-to-end testing in the PR description including prompt + reply |
phdargen
reviewed
Aug 9, 2025
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@coinbase/agentkit": minor | |||
phdargen
reviewed
Aug 9, 2025
| "@coinbase/cdp-sdk": "^1.3.0", | ||
| "@coinbase/coinbase-sdk": "^0.20.0", | ||
| "@jup-ag/api": "^6.0.39", | ||
| "@noves/intent-ethers-provider": "^0.1.3", |
Contributor
There was a problem hiding this comment.
Is there a particular reason why this doesn't use noves-sdk instead? ethers dependency appears unnecessary here
phdargen
reviewed
Aug 9, 2025
|
|
||
| ## Adding New Actions | ||
|
|
||
| To add new Alchemy actions: |
phdargen
reviewed
Aug 9, 2025
| */ | ||
| constructor() { | ||
| super("noves", []); | ||
| this.intentProvider = new IntentProvider(); |
Contributor
There was a problem hiding this comment.
Does this not require an API key?
phdargen
reviewed
Aug 9, 2025
| }) | ||
| async getTranslatedTransaction(args: z.infer<typeof NovesTranslatedTxSchema>): Promise<string> { | ||
| try { | ||
| const tx = await this.intentProvider.getTranslatedTx(args.chain, args.tx); |
Contributor
There was a problem hiding this comment.
I think would be better to default to the walletProvider.getNetwork here. Might need a untility function to convert CDP network format to Noves format, eg base-mainnet -> base
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noves Action Provider
Description
This PR adds a new Noves action provider for AgentKit that enables users to interact with Noves Intents to retrieve data featuring: human-readable transaction descriptions, current/historical token prices, and recent transactions.
Tests / Example
Showcase using Vercel/ai chatbot.
action-provider-ai-chat.webm
Checklist
A couple of things to include in your PR for completeness: