Skip to content

fix: add native JSON type support for SQL Server 2025 #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DiscountDarcy wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add native JSON type support for SQL Server 2025 #313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions models/Grammars/SqlServerGrammar.cfc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -852,11 +852,11 @@ component extends="qb.models.Grammars.BaseGrammar" singleton accessors="true" {
}

function typeJson( column ) {
return "NVARCHAR(MAX)";
return "JSON";
}

function typeJsonb( column ) {
return "NVARCHAR(MAX)";
return "JSON";
}

function typeLongText( column ) {
Expand Down
4 changes: 2 additions & 2 deletions tests/specs/Schema/SqlServerSchemaBuilderSpec.cfc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,11 +121,11 @@ component extends="tests.resources.AbstractSchemaBuilderSpec" {
}

function json() {
return [ "CREATE TABLE [users] ([personalizations] NVARCHAR(MAX) NOT NULL)" ];
return [ "CREATE TABLE [users] ([personalizations] JSON NOT NULL)" ];
}

function jsonb() {
return [ "CREATE TABLE [users] ([personalizations] NVARCHAR(MAX) NOT NULL)" ];
return [ "CREATE TABLE [users] ([personalizations] JSON NOT NULL)" ];
}

function lineString() {
Expand Down
Loading