setup_nodejs: restore the npm allowScripts bypass lost in the migration - #18
Merged
Conversation
Contributor
Try this branchThe engine and the scripts resolve independently, so a production script can COMMUNITY_SCRIPTS_CORE_URL=https://raw.githubusercontent.com/community-scripts/core/fix/npm-allow-scripts-policy \
bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVED/main/ct/debian.sh)"Swap Run a script from a fork as wellcurl -fsSL https://raw.githubusercontent.com/community-scripts/core/fix/npm-allow-scripts-policy/tools/run.sh |
bash -s -- https://raw.githubusercontent.com/YOU/ProxmoxVED/your-branch ct/debian.sh \
https://raw.githubusercontent.com/community-scripts/core/fix/npm-allow-scripts-policyNote that Useful flags while testing
|
npm 11 added allowScripts: dependency install hooks are skipped unless the package is covered, and npm still exits 0. Installing an app with native addons therefore "succeeds" with nothing built. ProxmoxVE#16280 added the guard to misc/tools.func on 2026-08-08. It did not come along when setup_nodejs moved here, and this file had no occurrence of allowScripts at all. The line is copied back verbatim. Reported for n8n: update ran clean, printed "Updated successfully!", and left the service dead with DriverPackageNotInstalledError, because sqlite3 fetches its binding from the install hook that was skipped. 272 ct/ and install/ scripts call setup_nodejs, so every app with native addons was on this path. Refs community-scripts/ProxmoxVE#16973
MickLesk
force-pushed
the
fix/npm-allow-scripts-policy
branch
from
September 2, 2026 15:24
ce77169 to
e854dea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✍️ Description
Restores the npm
allowScriptsbypass that was lost whensetup_nodejsmoved from ProxmoxVEmisc/tools.funcintolib/runtime.func.npm 11 added
allowScripts: dependency install hooks are skipped unless the package is covered, and npm still exits 0. Apps with native addons therefore "install" with nothing built. ProxmoxVE#16280 added the guard on 2026-08-08; this file had no occurrence of it at all. The line is copied back verbatim, in the same place.Surfaced on n8n: update printed "Updated successfully!" and left the service dead with
DriverPackageNotInstalledError, because sqlite3 fetches its binding from the skipped hook. 272ct/andinstall/scripts callsetup_nodejs, so every app with native addons was affected.🔗 Related Issue
Fixes community-scripts/ProxmoxVE#16973
✅ Prerequisites (X in brackets)
bash -nand that the inserted line is byte-identical to ProxmoxVEmisc/tools.func:7774.API.txt.🤖 AI Assistance (X in brackets)
🛠️ Type of Change (X in brackets)
README,docs/,CONTRIBUTING.md, or other docs.