feat: Support custom CLI image for verify-enterprise-contract task#8
Closed
cuipinghuo wants to merge 1 commit into
Closed
feat: Support custom CLI image for verify-enterprise-contract task#8cuipinghuo wants to merge 1 commit into
cuipinghuo wants to merge 1 commit into
Conversation
When CUSTOM_EC_CLI_IMAGE and CUSTOM_EC_TASK_YAML env vars are set, the e2e tests load the task definition from disk, replace all quay.io/conforma/cli step images with the custom image, and embed the patched task inline instead of resolving it from a bundle. This enables CLI PRs to be validated against their own code rather than the mainline release. Ref: EC-1913 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When CUSTOM_EC_CLI_IMAGE and CUSTOM_EC_TASK_YAML env vars are set, the e2e tests load the task definition from disk, replace all quay.io/conforma/cli step images with the custom image, and embed the patched task inline instead of resolving it from a bundle. This enables CLI PRs to be validated against their own code rather than the mainline release.
Ref: EC-1913