test(plpgsql-deparser): add trigger function fixture with FOUND/NEW/OLD/TG_OP examples #278
+65
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LD/TG_OP examples - Add trigger-function.sql fixture demonstrating PL/pgSQL special variables - Add trigger-function.sql to pretty test list - Generate snapshots showing uppercase FOUND/NEW/OLD/TG_OP handling This fixture tests the deparser's handling of PL/pgSQL special variables (FOUND, NEW, OLD, TG_OP) which should be output in uppercase without quotes.
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new test fixture for PL/pgSQL trigger functions that demonstrates the deparser's handling of special variables:
TG_OP,NEW,OLD, andFOUND. These are PL/pgSQL reserved words that should be output in uppercase without quotes.The fixture covers common trigger patterns:
TG_OPfor INSERT/UPDATE/DELETE operationsNEWandOLDrecord variablesFOUNDto check if a previous statement found rowsReview & Testing Checklist for Human
TG_OP,NEW,OLD,FOUNDwithout quotes (they do)Notes
This fixture was added as part of work on AST-based procedure generators in constructive-db (PR #319). The snapshots confirm that the pgsql-parser deparser already correctly handles these PL/pgSQL special variables.
Requested by: Dan Lynch (@pyramation)
Link to Devin run: https://app.devin.ai/sessions/6c4e0d41e8d445cebebab85e29243ab2