Skip to content

[skip-ci] TMT: initial enablement#820

Draft
lsm5 wants to merge 4 commits intocontainers:mainfrom
lsm5:packit-tmt
Draft

[skip-ci] TMT: initial enablement#820
lsm5 wants to merge 4 commits intocontainers:mainfrom
lsm5:packit-tmt

Conversation

@lsm5
Copy link
Copy Markdown
Member

@lsm5 lsm5 commented Sep 28, 2023

For local runs:
tmt run --all will by default spawn virtual machines for running each test.

tmt run --all provision --how local will run tests on the local machine.

The test run will echo the results dir at the very beginning. The actual results can be found in:
$TEST_RESULTS_DIR/plans/$TEST_NAME/execute/data/guest/default-0/script-00-1/output.txt

so for example:
/var/tmp/tmt/run-022/plans/validate_test/execute/data/guest/default-0/script-00-1/output.txt

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lsm5 lsm5 changed the title TMT: add validate test TMT: initial enablement Sep 28, 2023
@lsm5
Copy link
Copy Markdown
Member Author

lsm5 commented Sep 28, 2023

Feel free to ignore this PR until I ping you.

@packit-as-a-service
Copy link
Copy Markdown

Ephemeral COPR build failed. @containers/packit-build please check.

@packit-as-a-service
Copy link
Copy Markdown

TMT validate test failed. @containers/packit-build please check.

@packit-as-a-service
Copy link
Copy Markdown

TMT integration tests failed. @containers/packit-build please check.

@packit-as-a-service
Copy link
Copy Markdown

TMT unit tests failed. @containers/packit-build please check.

@packit-as-a-service
Copy link
Copy Markdown

TMT validate test failed. @containers/packit-build please check.

@packit-as-a-service
Copy link
Copy Markdown

TMT integration tests failed. @containers/packit-build please check.

@packit-as-a-service
Copy link
Copy Markdown

TMT validate test failed. @containers/packit-build please check.

@packit-as-a-service
Copy link
Copy Markdown

TMT unit tests failed. @containers/packit-build please check.

@packit-as-a-service
Copy link
Copy Markdown

TMT validate test failed. @containers/packit-build please check.

@packit-as-a-service
Copy link
Copy Markdown

TMT integration tests failed. @containers/packit-build please check.

@packit-as-a-service
Copy link
Copy Markdown

TMT unit tests failed. @containers/packit-build please check.

@packit-as-a-service
Copy link
Copy Markdown

TMT validate test failed. @containers/packit-build please check.

1 similar comment
@packit-as-a-service
Copy link
Copy Markdown

TMT validate test failed. @containers/packit-build please check.

@packit-as-a-service
Copy link
Copy Markdown

TMT unit tests failed. @containers/packit-build please check.

@packit-as-a-service
Copy link
Copy Markdown

TMT integration tests failed. @containers/packit-build please check.

@packit-as-a-service
Copy link
Copy Markdown

TMT validate test failed. @containers/packit-build please check.

@packit-as-a-service
Copy link
Copy Markdown

TMT unit tests failed. @containers/packit-build please check.

@packit-as-a-service
Copy link
Copy Markdown

TMT validate test failed. @containers/packit-build please check.

@packit-as-a-service
Copy link
Copy Markdown

TMT unit tests failed. @containers/packit-build please check.

@packit-as-a-service
Copy link
Copy Markdown

TMT integration tests failed. @containers/packit-build please check.

@packit-as-a-service
Copy link
Copy Markdown

TMT validate test failed. @containers/packit-build please check.

@packit-as-a-service
Copy link
Copy Markdown

TMT unit tests failed. @containers/packit-build please check.

@packit-as-a-service
Copy link
Copy Markdown

TMT integration tests failed. @containers/packit-build please check.

@packit-as-a-service
Copy link
Copy Markdown

TMT unit tests failed. @containers/packit-build please check.

@lsm5 lsm5 force-pushed the packit-tmt branch 2 times, most recently from 436631e to 0ad34bb Compare August 1, 2024 19:10
@lsm5 lsm5 force-pushed the packit-tmt branch 2 times, most recently from b02370d to 92a4f0b Compare October 31, 2024 14:32
Comment thread Makefile Outdated
Comment on lines +125 to +132
# The TEST_PLUGINS envvar is used by bats to specify path to test-plugins
# directory
ifdef TEST_PLUGINS
$(info Skipping examples build as TEST_PLUGINS is set)
integration: $(CARGO_TARGET_DIR)
else
integration: $(CARGO_TARGET_DIR) examples
endif
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should just drop the examples dependency instead of making it more complicated. We do not depend on build either so it is not much different.

Comment thread rpm/netavark.spec
Requires: %{name} = %{epoch}:%{version}-%{release}

%description tests
%{summary}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had this discussion recently about the podman RHEL rpm that this is not supported. So we should make sure if this ever gets top RHEL we do not ship it outside of the gating env if possible (i.e. follow whatever we decided to do with the podman rpm).

Outside of the bats test we do not support these examples either upstream. So maybe add the description here that these are test only binaries for gating and not recommended/supported for any other use.

@lsm5 lsm5 force-pushed the packit-tmt branch 3 times, most recently from 30b1e5b to 6e98139 Compare December 26, 2024 13:53
@lsm5
Copy link
Copy Markdown
Member Author

lsm5 commented Dec 26, 2024

cs10 blocked on bridge-utils absence: https://bugzilla.redhat.com/show_bug.cgi?id=2334212

@lsm5 lsm5 force-pushed the packit-tmt branch 7 times, most recently from 0db8f31 to a588807 Compare December 30, 2024 10:30
@Luap99
Copy link
Copy Markdown
Member

Luap99 commented Jan 7, 2025

cs10 blocked on bridge-utils absence: https://bugzilla.redhat.com/show_bug.cgi?id=2334212

@lsm5 FYI I don't think we need that package here since 71d8a5a

So just drop the dep.

@lsm5 lsm5 force-pushed the packit-tmt branch 2 times, most recently from 74f6afc to 64ff7d0 Compare February 11, 2025 11:11
@lsm5
Copy link
Copy Markdown
Member Author

lsm5 commented Feb 11, 2025

/packit retest-failed

@lsm5
Copy link
Copy Markdown
Member Author

lsm5 commented Feb 11, 2025

@Luap99 iptables tests are failing on F41+ and CS10. Should iptables be installed or these tests skipped?

@Luap99
Copy link
Copy Markdown
Member

Luap99 commented Feb 11, 2025

@Luap99 iptables tests are failing on F41+ and CS10. Should iptables be installed or these tests skipped?

We should test all so we need to install them all but I think you are already doing that.

The main issue is that the rpm uses a different default then what a regular from source build does. So the test must be fixed to work regardless of what driver is sued as default.

Then there is a second issue AFAIK centos 10 dropped iptables support so the iptables tests cannot run there at all so we need to figure out how to skip only the iptables based tests there.

And then I see another firewald driver issue, I think @mheon firewalld code requires a relatively recent firewalld so they might have to be skipped on centos 9

So overall quite a few things to figure out

@packit-as-a-service
Copy link
Copy Markdown

Tests failed. @containers/packit-build please check.

lsm5 added 4 commits May 8, 2026 15:26
Add TMT test plans and definitions for validate, unit, integration,
podman, and dhcp tests on Fedora and CentOS Stream.

Signed-off-by: Lokesh Mandvekar <lsm5@linux.com>
Configure Packit for COPR builds and TMT testing on Fedora and CentOS
Stream. Enable ELN builds and add test jobs with podman-next repository.

Signed-off-by: Lokesh Mandvekar <lsm5@linux.com>
- Add netavark-tests subpackage with test files
- Install netavark-dhcp-proxy-client binary
- Add TEST_PLUGINS environment variable for test plugins path
- Update .gitignore for TMT work directories

Signed-off-by: Lokesh Mandvekar <lsm5@linux.com>
Signed-off-by: Lokesh Mandvekar <lsm5@linux.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants