Oprava PHPStan chyby instanceof.alwaysTrue u Presenter::getRequest()

[radimvaculik]

Problem

The PHPStan CI job (which runs composer update → latest dependencies) fails on master:

Instanceof between Nette\Application\Request and Nette\Application\Request will always evaluate to true.
 src/Datagrid.php:1952  instanceof.alwaysTrue

Since nette/application v3.3.0, Presenter::getRequest() returns a non-nullable Nette\Application\Request (previously ?Request). The defensive instanceof Request guard in handleEdit() therefore becomes always-true and PHPStan reports it.

This is unrelated to any feature work — it is pure dependency drift and reproduces on a clean master (verified locally with nette/application upgraded to v3.3.0).

Fix

handleEdit() is a signal handler (handle*), so getPresenterInstance()->getRequest() is always set while it runs — it can never be null there. The instanceof Request guard was dead defensive code left over from when getRequest() was typed ?Request. It is removed, along with the now-unused use Nette\Application\Request; import.

Verification

• make phpstan passes with nette/application v3.3.0 installed (the version CI resolves).
• Full test suite passes (33 tests, 1 skipped — MySQL not running locally).

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.80%. Comparing base (d9144ab) to head (88e0043).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1296      +/-   ##
==========================================
+ Coverage   48.77%   48.80%   +0.03%     
==========================================
  Files          61       61              
  Lines        2901     2899       -2     
==========================================
  Hits         1415     1415              
+ Misses       1486     1484       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.