update override capi-port implementation#106
Open
dharanikesav wants to merge 3 commits intocouchbase:masterfrom
Open
update override capi-port implementation#106dharanikesav wants to merge 3 commits intocouchbase:masterfrom
dharanikesav wants to merge 3 commits intocouchbase:masterfrom
Conversation
Contributor
Author
|
@ceejatec kindly review this change and accept is everything is ok. This is blocking us in many places. |
With earlier approach CAPI PORT was overridden even where port was not specified. Fixed that issue with this commit. Now, CAPI PORT will be overridden only when the value is specified
Contributor
Author
|
@ceejatec could you please have a look at this change and merge if possible |
Contributor
Author
|
@ceejatec Hi, Could you please verify and merge this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
current implementation of override capi port is not working as expected with latest couchbase images. So, updated the implementation