set docker image tag to git-sha aswell#4289
Merged
extrawurst merged 2 commits intomainfrom Mar 24, 2026
Merged
Conversation
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
extrawurst
changed the title
extrawurst
force-pushed
the
tag-docker-images-with-git-sha
branch
from
ad36162 to
5900d13
Compare
extrawurst
force-pushed
the
tag-docker-images-with-git-sha
branch
from
5900d13 to
315fa79
Compare
tilacog
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently only set branch names and git-tags as additional docker image tags. it would make it easier to find the offending git commit breaking staging if we had also a docker tag of the git short-sha on the image