-
Notifications
You must be signed in to change notification settings - Fork 151
Add a quickstart for composing Kubernetes resources (apps) with Crossplane #864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…plane Signed-off-by: Craig Wilhite <craig@upbound.io>
cbc55f5 to
e1323fa
Compare
✅ Deploy Preview for crossplane ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
negz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two nits but overall LGTM. Thank you!
| metadata: | ||
| namespace: default | ||
| annotations: | ||
| krm.kcl.dev/composition-resource-name: "deployment" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't needed in P&T.
| @@ -0,0 +1,545 @@ | |||
| --- | |||
| title: App Compositions Quickstart | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| title: App Compositions Quickstart | |
| title: App Quickstart |
Nit: The other titles are e.g. "AWS Quickstart", "GCP Quickstart" - without "Composition".
"App Model Quickstart" might be good too.
|
@cwilhit thank you for the work you put into this PR. One important bit of context that has changed since this PR was opened: That said, there is still a useful angle here. Some features (for example things like So if you would like to continue this work, we would be happy to review a refreshed PR that:
For now, we will close this PR since it no longer aligns with the current docs state, but we would genuinely welcome a revised version. |

This PR adds a guide to the main branch of the docs for how to compose Kubernetes objects (for app scenarios) using provider-kubernetes. There's an implementation with both patch-and-transform and KCL.
This guide assumes the user completes the prior AWS/Azure/GCP quickstart first, so it glosses over explanations of core Crossplane concepts.